Fix Race Condition between RenewMessage and DeleteMessage #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytian
changed the title
cgillum
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a race condition occurs between RenewMessage and DeleteMessage, and RenewMessage wins, DeleteMessage fails with a MessageGone error. This happens because DeleteMessage may be using a snapshot of the QueueMessage that is already expired or invalid.
After UpdateMessage, a new QueueMessage instance is created, but DeleteMessage might still reference the old instance and its outdated pop receipt. To prevent this, we should always refer to the OriginalQueueMessage, which contains the most up-to-date information.